On 07/21/2010 07:27 PM, Marcelo Tosatti wrote:

Also should undo vmx.rmode.* ?
Elaborate?
Undo vmx.rmode assignments on cancel_injection.

Hm. Doesn't vmx_complete_interrupts() have to do that anyway if an injection fails?

Ah:

vmx_vcpu_run()
{
...
    vmx->idt_vectoring_info = vmcs_read32(IDT_VECTORING_INFO_FIELD);
    if (vmx->rmode.irq.pending)
        fixup_rmode_irq(vmx);

...

    vmx_complete_interrupts(vmx);

So I'll just move that bit into vmx_complete_interrupts.  Good catch.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to