On Wed, Aug 18, 2010 at 5:46 PM, Avi Kivity <[email protected]> wrote:
> On 08/18/2010 05:32 PM, Mohammed Gamal wrote:
>>
>> On Wed, Aug 18, 2010 at 5:11 PM, Avi Kivity<[email protected]> wrote:
>>>
>>> On 08/18/2010 05:09 PM, Avi Kivity wrote:
>>>>
>>>> On 08/18/2010 03:46 PM, Mohammed Gamal wrote:
>>>>>
>>>>> On Wed, Aug 18, 2010 at 10:36 AM, Avi Kivity<[email protected]> wrote:
>>>>>>
>>>>>> Signed-off-by: Avi Kivity<[email protected]>
>>>>>> ---
>>>>>> arch/x86/kvm/x86.c | 1 +
>>>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>>>
>>>>>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>>>>>> index f6a31a1..e2b0e36 100644
>>>>>> --- a/arch/x86/kvm/x86.c
>>>>>> +++ b/arch/x86/kvm/x86.c
>>>>>> @@ -3967,6 +3967,7 @@ int kvm_inject_realmode_interrupt(struct
>>>>>> kvm_vcpu
>>>>>> *vcpu, int irq)
>>>>>>
>>>>>> vcpu->arch.emulate_ctxt.decode.op_bytes = 2;
>>>>>> vcpu->arch.emulate_ctxt.decode.ad_bytes = 2;
>>>>>> + vcpu->arch.emulate_ctxt.decode.eip = kvm_rip_read(vcpu);
>>>>>
>>>>> I think it'd make more sense to make
>>>>> vcpu->arch.emulate_ctxt.decode.eip = vcpu->arch.emulate_ctxt.eip, as
>>>>> we already initlialize the emulation context eip. It's not going to
>>>>> make any real difference, but it's more readable this way I suppose,
>>>>> and is symmetric to the assignment of the emulation context eip value
>>>>> after the call to emulate_int_real()
>>>>
>>>> Right, patch updated.
>>>>
>>> btw, with the other fixes in non-atomic-injection the bios is able to
>>> boot
>>> up to the "no bootable device" message.
>>
>> Did u try running it with any actual guests?
>
> I did, the disk is not recognized, so something's still broken.
So far I get hard disk images recognized, but cdrom images aren't.
>
> --
> I have a truly marvellous patch that fixes the bug which this
> signature is too narrow to contain.
>
>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
