Re: [PATCH 03/14] KVM: x86 emulator: implement DAS (opcode 2F)

[Avi Kivity]

 On 08/22/2010 03:18 PM, Avi Kivity wrote:

Signed-off-by: Avi Kivity<a...@redhat.com>
---
  arch/x86/kvm/emulate.c |   37 ++++++++++++++++++++++++++++++++++++-
  1 files changed, 36 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index f6f93b9..4cbc884 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -2176,6 +2176,40 @@ static int em_push(struct x86_emulate_ctxt *ctxt)
        return X86EMUL_CONTINUE;
  }

+static int em_das(struct x86_emulate_ctxt *ctxt)
+{
+       struct decode_cache *c =&ctxt->decode;
+       u8 al, old_al;
+       bool af, cf, old_cf;
+
+       cf = ctxt->eflags&  X86_EFLAGS_CF;
+       al = c->dst.val;
+
+       old_al = al;
+       old_cf = cf;
+       cf = false;
+       af = ctxt->eflags&  X86_EFLAGS_AF;
+       if ((al&  0x0f)>  9 || af) {
+               al -= 6;
+               cf = old_cf | (al>= 250);
+               af = true;
+       } else {
+               af = false;
+       }
+       if (old_al>  0x99 || old_cf) {
+               al -= 0x60;
+               cf = true;
+       }
+
+       c->dst.val = al;
+       ctxt->eflags&= ~(X86_EFLAGS_AF | X86_EFLAGS_CF);
+       if (cf)
+               ctxt->eflags |= X86_EFLAGS_CF;
+       if (af)
+               ctxt->eflags |= X86_EFLAGS_AF;
+       return X86EMUL_CONTINUE;
+}
+

Missing the following hunk:

     }

     c->dst.val = al;
+    /* Set PF, ZF, SF */
+    c->src.type = OP_IMM;
+    c->src.val = 0;
+    c->src.bytes = 1;
+    emulate_2op_SrcV("or", c->src, c->dst, ctxt->eflags);
     ctxt->eflags &= ~(X86_EFLAGS_AF | X86_EFLAGS_CF);
     if (cf)
         ctxt->eflags |= X86_EFLAGS_CF;


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html