On 08/24/2010 03:07 PM, Isaku Yamahata wrote:
On Tue, Aug 24, 2010 at 02:42:18PM +0300, Avi Kivity wrote:
  On 08/24/2010 02:35 PM, Isaku Yamahata wrote:
Add Cc: [email protected].

MAX_PCI_SLOTS should be in pci.h instead of qdev.h?
And the name should be start with PCI_ prefix for consistency?

Except that, the patches look okay.

These aren't slots, are they?  They are functions.
The function checks if given $slot.$fn (or $slot) is valid.
So it's slots. max 32.

+    assert(devfn<  PCIBUS_MAX_DEVICES);


Looks like we're comparing a function number to PCIBUS_MAX_DEVICES.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to