Re: [PATCH 22/27] KVM: MMU: Refactor mmu_alloc_roots function

[Avi Kivity]

 On 09/07/2010 11:39 PM, Marcelo Tosatti wrote:

@@ -2406,16 +2441,11 @@ static int mmu_alloc_roots(struct kvm_vcpu *vcpu)
                        root_gfn = pdptr>>  PAGE_SHIFT;
                        if (mmu_check_root(vcpu, root_gfn))
                                return 1;
-               } else if (vcpu->arch.mmu.root_level == 0)
-                       root_gfn = 0;
-               if (vcpu->arch.mmu.direct_map) {
-                       direct = 1;
-                       root_gfn = i<<  30;
                }
                spin_lock(&vcpu->kvm->mmu_lock);
                kvm_mmu_free_some_pages(vcpu);
                sp = kvm_mmu_get_page(vcpu, root_gfn, i<<  30,
-                                     PT32_ROOT_LEVEL, direct,
+                                     PT32_ROOT_LEVEL, 0,
                                      ACC_ALL, NULL);
Should not write protect the gfn for nonpaging mode.


nonpaging mode should have direct_map set, so wouldn't enter this path 
at all.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html