The value of 'vcpu->arch.mmu.pae_root' is not modified, so we can update 
'root_hpa'
out of the loop

Xiao Guangrong <[email protected]>
---
 arch/x86/kvm/mmu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index c94c432..3630046 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -2393,8 +2393,8 @@ static int mmu_alloc_direct_roots(struct kvm_vcpu *vcpu)
                        ++sp->root_count;
                        spin_unlock(&vcpu->kvm->mmu_lock);
                        vcpu->arch.mmu.pae_root[i] = root | PT_PRESENT_MASK;
-                       vcpu->arch.mmu.root_hpa = __pa(vcpu->arch.mmu.pae_root);
                }
+               vcpu->arch.mmu.root_hpa = __pa(vcpu->arch.mmu.pae_root);
        } else
                BUG();
 
@@ -2466,8 +2466,8 @@ static int mmu_alloc_shadow_roots(struct kvm_vcpu *vcpu)
                spin_unlock(&vcpu->kvm->mmu_lock);
 
                vcpu->arch.mmu.pae_root[i] = root | pm_mask;
-               vcpu->arch.mmu.root_hpa = __pa(vcpu->arch.mmu.pae_root);
        }
+       vcpu->arch.mmu.root_hpa = __pa(vcpu->arch.mmu.pae_root);
 
        /*
         * If we shadow a 32 bit page table with a long mode page
-- 
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to