On 04/03/2011 06:59 PM, Takuya Yoshikawa wrote:
> I think it's easier to just write directly instead of going through
> 'struct operand'.
>
> Probably emulate_push() should do the write (look at segmented_write()
> in my 'Emulator segment checks' patchset), and everything else can call
> that. 'struct operand' is for multiplexing register/memory accesses,
> which is not the case with the stack.
I agree with you. I will update!
IMHO, we are using dst operand for too many things.
In the case of CMP, I first tried to use src2 to clearly follow the
SDM's "second source operand" terminology. But it seemed not worth
it now.
Ah, CMP is encoded as dst/src, so it's best to just disable writeback
there. We could have a bit in the decode tables to auto-disable
writeback, but not sure it is worth it.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
