On Wed, Apr 27, 2011 at 05:29:10PM +0300, Avi Kivity wrote: > On 04/27/2011 05:04 PM, Jan Kiszka wrote: > >> > >> I put kvm_msix_message in pci.h to avoid having every pci device pull in > >> kvm.h > >> is anything wrong with that? Maybe just rename it to make it generic > >> for msi and leave if where it is. > > > >kvm.h shall provide kvm related types, not some unrelated header. That's > >even more important with MSI support for non-PCI devices (aka HPET). > > We could have an MSIMessage type that abstracts the general > facility, and let it embed a KVMMsiMessage that contains just the > gsi.
The whole structure is only needed for kvm though: no one else seems to want an MSIMessage. > -- > error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
