On 05/09/2011 11:53 PM, Pekka Enberg wrote:
>> From: Cyrill Gorcunov <[email protected]>
>> Subject: [PATCH] kvm tools: PCI -- Make PCI device numbers being unique v2
>>
>> PCI device numbers must be unique on a bus (as a part
>> of Bus/Device/Function tuple).Make it so. Note the patch
>> is rather a fast fix since we need a bit more smart pci device
>> manager (in particular multiple virtio block devices most
>> probably should lay on a separate pci bus).
>>
>> v2: Sasha spotted the nit in virtio_rng__init, ioport
>> function was touched insted of irq__register_device.
>
> Hey, I don't like the new patch subject trend you're trying to start at all.
> You can make it
>
> kvm tools,pci: Make PCI device numbers unique
>
> but in this particular case "PCI" already appears in the title so
>
> kmv tools: Make PCI device numbers unique
>
> is the right thing to do.
PCI stands for kvm tools subsystem, but if you like more the last -- I'm fine
with it.
>
> In addition, the changelog doesn't really tell me much. Does it fix something?
> Why would we need a "smart pci device manager" and why is that relevant for
> this
> patch? Hmmh?
>
> Pekka
The thing is that at moment the id's passed to MP table is incorrect, they are
to be
5 bits long (mp spec). The smart manager we need -- it's because there could be
multiple
virtio block device and they _are_ to be separated pci devices, ie with own
numbers and
intx# assignents. As result we probably should have such virtio devices to lay
on a separate
pci bus, or if the number of pci devices exceed the width of address line then
we should pass them to another pci bus. That is what I had in mind but I'm not
sure all this
should come to the changelog.
--
Cyrill
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
