On Fri, 2011-05-13 at 10:19 +0200, Ingo Molnar wrote: > FYI, the tools/kvm build still fails on 32-bit: > > cc1: warnings being treated as errors > qcow.c: In function ‘qcow1_write_sector’: > qcow.c:307: error: comparison between signed and unsigned integer expressions > make: *** [qcow.o] Error 1 > make: *** Waiting for unfinished jobs.... > > using: > > gcc version 4.4.4 20100630 (Red Hat 4.4.4-10) (GCC) > > The patch below addresses them but i haven't tested it beyond checking that > it > builds. > > The double cast of userspace_addr is doubly sad - it highlights our > 32-bitness > problems which are visible in the guest_pfn_to_host() function as well.
KVM API uses 64-bit addresses no matter the host bitness, so we can't really get around doing these sort of casts. -- Sasha. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
