Re: [PATCH 04/16] qemu-kvm: Drop IRQ0 override test from ioapic_set_irq

[Avi Kivity]

On 05/13/2011 03:13 PM, Jan Kiszka wrote:
The IRQ0 override is not configurable while using the user space IOAPIC.
When the in-kernel irqchip is active, ioapic_set_irq is never called. So
drop this useless test.

@@ -146,7 +145,7 @@ static void ioapic_set_irq(void *opaque, int vector, int 
level)
       * the cleanest way of doing it but it should work. */

      DPRINTF("%s: %s vec %x\n", __func__, level ? "raise" : "lower", vector);
-    if (vector == 0&&  irq0override) {
+    if (vector == 0) {
          vector = 2;
      }
      if (vector>= 0&&  vector<  IOAPIC_NUM_PINS) {

Incidentally, the variable should be called pin, not vector, and 
gsi->ioapic/pic wiring should be done outside the ioapic code.

--

error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html