On 05/19/2011 11:08 PM, Cyrill Gorcunov wrote:
...
>>
>> What prevents nr_online_cpus from being greater than KVM_NR_CPUS? Since
>> that latter is a #define, might want to change 'else if' to if there.
>>
>> David
>>
> 
> Good catch! We should add a constraint here and limit it to KVM_NR_CPUS.
> 

Heh, actually it get catched futher in code by

        max_cpus = kvm__max_cpus(kvm);

        if (nrcpus > max_cpus) {
                printf("  # Limit the number of CPUs to %d\n", max_cpus);
                kvm->nrcpus     = max_cpus;
        }

so no issue here (except that MP table can support a limited number of
cpus and for 32bit apic addressing we need ACPI support implemented I think).

-- 
            Cyrill
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to