From: Takuya Yoshikawa <[email protected]> A trivial typo was found in the following commit: commit 7753ed6043bfce55dc0c407490896632014b677e KVM: x86 emulator: drop vcpu argument from segment/gdt/idt callbacks
When the table indicator flag is set, when the selector selects the current LDT, get_descriptor_table_ptr() returns without setting the size and address of the table. Guests will see #GP if this happens. Signed-off-by: Takuya Yoshikawa <[email protected]> --- Is this stable material? -- IIRC, someone reported a suspicous emulator bug recently. arch/x86/kvm/emulate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 3bc6b7a..b8b9748 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -1158,7 +1158,7 @@ static void get_descriptor_table_ptr(struct x86_emulate_ctxt *ctxt, u16 sel; memset (dt, 0, sizeof *dt); - if (!ops->get_segment(ctxt, &sel, &desc, NULL, VCPU_SREG_LDTR)); + if (!ops->get_segment(ctxt, &sel, &desc, NULL, VCPU_SREG_LDTR)) return; dt->size = desc_limit_scaled(&desc); /* what if limit > 65535? */ -- 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
