* Sasha Levin <[email protected]> wrote:

> @@ -598,6 +608,13 @@ int kvm_cmd_run(int argc, const char **argv, const char 
> *prefix)
>  
>       kvm__init_ram(kvm);
>  
> +     if (vnc) {
> +             pthread_t thread;
> +
> +             vesa__init(kvm);
> +             pthread_create(&thread, NULL, vesa__dovnc, kvm);
> +     }
> +

This should be encapsulated better, it should probably be all be done within 
vesa__init() and the only kv_cmd_run() exposure should be:

        vesa__init(kvm);

vesa__init() would wrap to an empty inline function if the library prereqs are 
not present.

Thanks,

        Ingo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to