On Mon, May 23, 2011 at 12:51:55PM -0400, Avi Kivity wrote:
> On 05/23/2011 07:43 PM, Roedel, Joerg wrote:
> > On Mon, May 23, 2011 at 11:49:17AM -0400, Avi Kivity wrote:
> >
> > > Joerg, is
> > >
> > > if (unlikely(cpu != vcpu->cpu)) {
> > > svm->asid_generation = 0;
> > > mark_all_dirty(svm->vmcb);
> > > }
> > >
> > > susceptible to cpu offline/online?
> >
> > I don't think so. This should be safe for cpu offline/online as long as
> > the cpu-number value is not reused for another physical cpu. But that
> > should be the case afaik.
> >
>
> Why not? offline/online does reuse cpu numbers AFAIK (and it must, if
> you have a fully populated machine and offline/online just one cpu).
Yes, you are right. There is a slight possibility that the asid is not
updated when a vcpu has asid_generation == 1 and hasn't been running on
another cpu while this given cpu was offlined/onlined. Very unlikely,
but we can not rule it out.
Probably we should make the local_vcpu_list from vmx generic, use it
from svm and fix it this way.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
