> From: Nadav Har'El [mailto:[email protected]] > Sent: Wednesday, May 25, 2011 9:26 PM > > On Wed, May 25, 2011, Tian, Kevin wrote about "RE: [PATCH 18/31] nVMX: > Implement VMLAUNCH and VMRESUME": > > > + if (!saved_vmcs02) > > > + return -ENOMEM; > > > + > > > > we shouldn't return error after the guest mode is updated. Or else move > > enter_guest_mode to a later place... > > I moved things around, but I don't think it matters anyway: If we return > ENOMEM, the KVM ioctl fails, and the whole L1 guest dies - it doesn't matter > at this point if we were in the middle of updating its state. >
yes but the code this way is cleaner that guest mode is set only when next we'll certainly enter L2. Thanks Kevin -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
