On Thu, 2011-05-26 at 13:31 -0700, Shirley Ma wrote: > On Thu, 2011-05-26 at 23:28 +0300, Michael S. Tsirkin wrote: > > On Thu, May 26, 2011 at 01:00:20PM -0700, Shirley Ma wrote: > > > 3. Add sleep in vhost shutting down instead of busy-wait for > > outstanding > > > DMAs. > > > > I still think this is not much better. We need to use a > > completion structure and wait on it instead. > > If this gets blocked thinkably a tx watchdog can fire and save us > > from blocking forver :) > > Ok, I can add a completion structure here.
The code here doesn't block forever during shutdown, it will release all outstanding userspace buffers anyway, see vhost_zerocopy_signal_used() shutdown case. Thanks Shirley -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
