On Sat, 18 Jun 2011 14:51:19 -0400, Sasha Levin <[email protected]> wrote: > On Sat, 2011-06-18 at 23:19 +0530, Aneesh Kumar K.V wrote: > > The TSTAT output formwat is wS. So not sure whey we > > need sizeof(u16)*2 in pdu length. > > See http://ericvh.github.com/9p-rfc/rfc9p2000.html#anchor32 > > "BUGS > > To make the contents of a directory, such as returned by read(5), > easy to parse, each directory entry begins with a size field. For > consistency, the entries in Twstat and Rstat messages also contain their > size, which means the size appears twice. For example, the Rstat message > is formatted as ``(4+1+2+2+n)[4] Rstat tag[2] n[2] (n-2)[2] type[2] > dev[4]...,'' where n is the value returned by convD2M." >
The value returned by virtio_p9_fill_stat will include the accounting for extra size field added to rstat reply. So we just need an additional sizeof(u16). Not sizeof(u16) * 2 right ? -aneesh -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
