On Fri, 2011-08-12 at 23:22 +0800, walimis wrote: > On Fri, Aug 12, 2011 at 06:20:54PM +0300, Sasha Levin wrote: > >Signed-off-by: Sasha Levin <[email protected]> > >--- > > tools/kvm/kvm-cmd.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > >diff --git a/tools/kvm/kvm-cmd.c b/tools/kvm/kvm-cmd.c > >index e85f22f..3a90d6d 100644 > >--- a/tools/kvm/kvm-cmd.c > >+++ b/tools/kvm/kvm-cmd.c > >@@ -24,6 +24,7 @@ struct cmd_struct kvm_commands[] = { > > { "balloon", kvm_cmd_balloon, NULL, 0 }, > > { "list", kvm_cmd_list, NULL, 0 }, > > { "version", kvm_cmd_version, NULL, 0 }, > >+ { "--version", kvm_cmd_version, NULL, 0 }, > Although it works, I think it's not good way to implement a option > as a command.
Since kvm tools isn't going to support options to 'kvm' itself, I believe that even though it looks somewhat hacky, it's the simplest and most correct solution. If we were going to add more parameters besides '--version' then yes, let's write a better interface. Perf for example allow '--version' by doing a strcmp() before command parsing, which is equally not that nice :) -- Sasha. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
