Yeah. I will fix them in the next version. -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Pekka Enberg Sent: Monday, November 21, 2011 5:06 PM To: Lan, Tianyu Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected] Subject: Re: [PATCH] kvm tools, qcow: Add the support for copy-on-write clusters
On Mon, Nov 21, 2011 at 9:12 AM, Lan Tianyu <[email protected]> wrote: > +/*Allocate clusters according to the size. Find a postion that > + *can satisfy the size. free_clust_idx is initialized to zero and > + *Record last position. > +*/ Can you please fix up your comments to use the following standard kernel style: /* * Allocate clusters according to the size. Find a postion that * can satisfy the size. free_clust_idx is initialized to zero and * Record last position. */ [ Whitespace after asterisk and starting line doesn't have text. ] > - rfb = qcow_read_refcount_block(q, clust_idx); > - if (!rfb) { > - pr_warning("L1: error while reading refcount table"); > + clust_new_start = qcow_alloc_clusters(q, q->cluster_size); > + if (clust_new_start < 0) { > + pr_warning("Cluster alloc error!"); Please drop the exclamation marks from pr_warning() and pr_error() messages. It just adds pointless noise. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
