Re: [patch 10/12] [PATCH] kvm-s390: storage key interface

[Carsten Otte]

On 09.12.2011 14:46, heica...@linux.vnet.ibm.com wrote:

On Fri, Dec 09, 2011 at 01:49:35PM +0100, Carsten Otte wrote:

This patch introduces an interface to access the guest visible
storage keys. It supports three operations that model the behavior
that SSKE/ISKE/RRBE instructions would have if they were issued by
the guest. These instructions are all documented in the z architecture
principles of operation book.

Signed-off-by: Carsten Otte<co...@de.ibm.com>
---

[...]

+       spin_lock(&current->mm->page_table_lock);
+       ptep = ptep_for_addr(addr);
+       if (!ptep)
+               goto out_unlock;

FWIW, this is also a bit odd: if the guest would perform a storage key
operation on such an address it would succeed. If the host will do it,
it will fail (which doesn't match your description above).
No?

Good catch, will fix.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html