On Mon, 19 Dec 2011, Avi Kivity wrote:
> -static int xen_log_start(CPUPhysMemoryClient *client, target_phys_addr_t
> phys_addr, ram_addr_t size)
> +static void xen_log_start(MemoryListener *listener,
> + MemoryRegionSection *section)
> {
> - XenIOState *state = container_of(client, XenIOState, client);
> + XenIOState *state = container_of(listener, XenIOState, memory_listener);
> + int r;
>
> - return xen_sync_dirty_bitmap(state, phys_addr, size);
> + r = xen_sync_dirty_bitmap(state, section->offset_within_address_space,
> + section->size);
> + assert(r >= 0);
> }
I really feel I should thank you for your work because you did a very
good job porting xen to the new api. In fact apart from the dirty bitmap
(Anthony is about to send a patch to fix the issue:
xen_sync_dirty_bitmap can actually fail sometimes), everything else
is done right and works correctly.
However I would have appreciated if you could have given us more time to
review the four patches you wrote: considering the time of the year both
Anthony and I were on vacation and didn't have a chance to read them
until today.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
