On 02/01/2012 12:45 PM, Stephan Bärwolf wrote:
> On 02/01/12 11:27, Avi Kivity wrote:
> >  
> > +static bool vendor_intel(struct x86_emulate_ctxt *ctxt)
> > +{
> > +   u32 eax, ebx, ecx, edx;
> Just to be clean:
>
> Shouldn't eax and ecx be initialized to zero?

Either get_cpuid() initializes them and returns true, or it returns
false and we never evaluate them.

> regards Stephan
> > +
> > +   return ctxt->ops->get_cpuid(ctxt, &eax, &ebx, &ecx, &edx)
> > +           && ebx == X86EMUL_CPUID_VENDOR_GenuineIntel_ebx
> > +           && ecx == X86EMUL_CPUID_VENDOR_GenuineIntel_ecx
> > +           && edx == X86EMUL_CPUID_VENDOR_GenuineIntel_edx;
> > +}
> > +
>




-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to