On Tuesday 12 June 2012, Takuya Yoshikawa wrote: > > > > Hmm, any reason why we're not just using the existing non-atomic > > __set_bit_le() here? I think the helpers in sfc and tulip can > > just get removed if you use those. > > __set_bit_le() assumes long word alignment and does endian conversion > when needed.
Ah, I see. > To be honest, I am a bit scared of changing drivers which I cannot test > on real hardware. Ok, let's take your patches as they are then. With the change to add clear_bit_le: Acked-by: Arnd Bergmann <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
