On 19 October 2012 19:46, Christoffer Dall
<[email protected]> wrote:
> On Wed, Oct 17, 2012 at 4:29 PM, Peter Maydell <[email protected]> 
> wrote:
>> This doesn't say whether userspace is allowed to make this ioctl
>> multiple times for the same device. This could be any of:
>>  * undefined behaviour
>>  * second call fails with some errno
>>  * second call overrides first one
>>
>
> I added an error condition EEXIST, but since this is trying to not be
> arm-vgic specific this is really up to the individual device - maybe
> we can have some polymorphic device that moves around later.
>
>> It also doesn't say that you're supposed to call this after CREATE
>> and before INIT of the irqchip. (Nor does it say what happens if
>> you call it at some other time.)
>>
>
> same non-device specific argument as above.

We could have a section in the docs that says "On ARM platforms
there are devices X and Y and they have such-and-such properties
and requirements" [and other devices later can have further docs
as appropriate].

-- PMM
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to