Re: [patch 10/16] x86: vdso: pvclock gettime support

[Glauber Costa]

On 11/01/2012 02:47 AM, Marcelo Tosatti wrote:
> +#ifdef CONFIG_PARAVIRT_CLOCK
> +
> +static notrace const struct pvclock_vsyscall_time_info *get_pvti(int cpu)
> +{
> +     const aligned_pvti_t *pvti_base;
> +     int idx = cpu / (PAGE_SIZE/PVTI_SIZE);
> +     int offset = cpu % (PAGE_SIZE/PVTI_SIZE);
> +
> +     BUG_ON(PVCLOCK_FIXMAP_BEGIN + idx > PVCLOCK_FIXMAP_END);
> +
> +     pvti_base = (aligned_pvti_t *)__fix_to_virt(PVCLOCK_FIXMAP_BEGIN+idx);
> +
> +     return &pvti_base[offset].info;
> +}
> +
Does BUG_ON() really do what you believe it does while in userspace
context? We're not running with the kernel descriptors, so this will
probably just kill the process without any explanation
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html