On Mon, Jan 21, 2013 at 07:05:43PM -0200, Marcelo Tosatti wrote:
> > + struct vcpu_vmx *vmx = to_vmx(vcpu);
> > +
> > + if (WARN_ONCE((vector > 255),
> > + "KVM VMX: vector (%d) out of range\n", vector))
> > + return;
>
> Please remove the WARN_ON, inject triple fault if this happens
> (and add a tracepoint).
>
Since this cannot be triggered by a guest triple fault is unwarranted.
Vector can be greater than 255 here only due to KVM bug, so WARN() or
even BUG() is appropriate.
--
Gleb.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
