On Tue, 2013-03-19 at 09:40 +0100, Stefan Hajnoczi wrote:
> On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote:
> > ---
> > hw/vhost.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/vhost.c b/hw/vhost.c
> > index 4d6aee3..0c52ec4 100644
> > --- a/hw/vhost.c
> > +++ b/hw/vhost.c
> > @@ -421,10 +421,12 @@ static void vhost_set_memory(MemoryListener *listener,
> > return;
> > }
> >
> > +#if 0
> > if (dev->started) {
> > r = vhost_verify_ring_mappings(dev, start_addr, size);
> > assert(r >= 0);
> > }
> > +#endif
>
> Please add a comment to explain why.
>
Btw, the output that Asias added in the failure case at the behest of
MST is here:
http://www.spinics.net/lists/target-devel/msg04077.html
MST seemed to think it may be a bug in cpu_physical_memory_map, but as
this worked with the original vhost-scsi code it would seem to indicate
something else at fault..
I'll be comparing what the original code did vs. vhost-scsi-pci to track
this down, but any extra ideas to track is down is appreciated. ;)
--nab
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
