On Wed, May 15, 2013 at 11:36:02AM -0700, Sanjay Lal wrote:
>
> On May 15, 2013, at 10:30 AM, Gleb Natapov wrote:
>
> > On Wed, May 15, 2013 at 09:54:24AM -0700, David Daney wrote:
> >> On 05/15/2013 08:54 AM, Sanjay Lal wrote:
> >>>
> >>> On May 14, 2013, at 2:27 AM, Gleb Natapov wrote:
> >>>
> >>>>>
> >>>>>
> >>>>> +EXPORT_SYMBOL(min_low_pfn); /* defined by bootmem.c, but not
> >>>>> exported by generic code */
> >>>>> +
> >>>> What you need this for? It is not used anywhere in this patch and by
> >>>> mips/kvm code in general.
> >>>
> >>> I did some digging around myself, since the linker keeps complaining that
> >>> it can't find min_low_pfn when compiling the KVM module. It seems that
> >>> it is indirectly pulled in by the cache management functions.
> >>>
> >>
> >> If it is really needed, then the export should probably be done at
> >> the site of the min_low_pfn definition, not in some random
> >> architecture file.
> >>
> > Definitely. We cannot snick it here like that. Please drop it from this
> > patch.
> >
>
> I did export min_low_pfn where it was defined (in .../mm/bootmem.c) as part
> of the original patch set. It conflicted with the ia64/metag ports.
> min_low_pfn is exported in arch/ia64/kernel/ia64_ksyms.c and in
> arch/metag/kernel/metag_ksyms.c.
>
> There was some chatter about this when the KVM/MIPS code ended up in
> linux-next. From what I can gather, the maintainers for the other
> architectures agreed that exporting this symbol in bootmem.c was fine and
> should flow from the MIPS tree. I'll do that as part of v2 of the patch set.
>
Make it a separate patch and send it to linux-kernel and
[email protected] and affected arch maintainers. Or you can add export
to arch/mips/kernel/mips_ksyms.c and ask Ralf to take it. I can take it
via kvm tree with Ralf's ack too. In the commit message have a good
explanation why it is needed please.
--
Gleb.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
