On Tue, May 14, 2013 at 03:13:42PM +0100, Marc Zyngier wrote: > Let userspace play with the guest registers. > > Reviewed-by: Christopher Covington <[email protected]> > Signed-off-by: Marc Zyngier <[email protected]> > --- /dev/null > +++ b/arch/arm64/kvm/guest.c ... > +static int get_core_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg) > +{ > + __u32 __user *uaddr = (__u32 __user *)(unsigned long)reg->addr; > + struct kvm_regs *regs = vcpu_gp_regs(vcpu); > + int nr_regs = sizeof(*regs) / sizeof(__u32);
Was there any conclusion on using __u32 rather than __u64 here? At least you should add a comment since it's slightly confusing. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
