Sure. Thanks for the suggestion.
On Tue, May 21, 2013 at 1:15 AM, Xiao Guangrong <[email protected]> wrote: > On 05/19/2013 12:52 PM, Jun Nakajima wrote: >> From: Nadav Har'El <[email protected]> >> >> Since link_shadow_page() is used by a routine in mmu.c, add an >> EPT-specific link_shadow_page() in paging_tmp.h, rather than moving >> it. >> >> Signed-off-by: Nadav Har'El <[email protected]> >> Signed-off-by: Jun Nakajima <[email protected]> >> Signed-off-by: Xinhao Xu <[email protected]> >> --- >> arch/x86/kvm/paging_tmpl.h | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h >> index 4c45654..dc495f9 100644 >> --- a/arch/x86/kvm/paging_tmpl.h >> +++ b/arch/x86/kvm/paging_tmpl.h >> @@ -461,6 +461,18 @@ static void FNAME(pte_prefetch)(struct kvm_vcpu *vcpu, >> struct guest_walker *gw, >> } >> } >> >> +#if PTTYPE == PTTYPE_EPT >> +static void FNAME(link_shadow_page)(u64 *sptep, struct kvm_mmu_page *sp) >> +{ >> + u64 spte; >> + >> + spte = __pa(sp->spt) | VMX_EPT_READABLE_MASK | VMX_EPT_WRITABLE_MASK | >> + VMX_EPT_EXECUTABLE_MASK; >> + >> + mmu_spte_set(sptep, spte); >> +} >> +#endif > > The only difference between this function and the current link_shadow_page() > is shadow_accessed_mask. Can we add a parameter to eliminate this difference, > some like: > > static void link_shadow_page(u64 *sptep, struct kvm_mmu_page *sp, bool > accessed) > { > u64 spte; > > spte = __pa(sp->spt) | PT_PRESENT_MASK | PT_WRITABLE_MASK | > shadow_user_mask | shadow_x_mask; > > if (accessed) > spte |= shadow_accessed_mask; > > mmu_spte_set(sptep, spte); > } > > ? > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jun Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
