> > + /*
> > + * The interrupt is shared, KVM support for the
> > featured unit
> > + * is detected at run-time.
> > + */
>
> This is a decent comment for the changelog, but for the code itself it
> seems fairly obvious if you look at the definition of
> kvmppc_supports_spe().
I will move it to change log.
>
> > + bool handled = false;
> > +
> > + if (kvmppc_supports_spe()) {
> > +#ifdef CONFIG_SPE
> > + if (cpu_has_feature(CPU_FTR_SPE))
>
> Didn't you already check this using kvmppc_supports_spe()?
It makes sense with the next patch. It handles the improbable case of having
CONFIG_ALTIVEC and CONFIG_SPE defined:
if (kvmppc_supports_altivec() || kvmppc_supports_spe()).
>
> > case BOOKE_INTERRUPT_SPE_FP_ROUND:
> > +#ifdef CONFIG_SPE
> > kvmppc_booke_queue_irqprio(vcpu,
> > BOOKE_IRQPRIO_SPE_FP_ROUND);
> > r = RESUME_GUEST;
> > break;
>
> Why not use kvmppc_supports_spe() here, for consistency?
I added cpu_has_feature(CPU_FTR_SPE) for the case specified above, but here
SPE_FP_ROUND is not shared with ALTIVEC. CONFIG_SPE is used in other places
in KVM without this check, shouldn't be all or nothing?
-Mike
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
