On Mon, Apr 13, 2015 at 08:59:21AM +0100, Alex Bennée wrote:

[...]

> >> +          /* MDSCR_EL1 */
> >> +          if (r->reg == MDSCR_EL1) {
> >> +                  if (p->is_write)
> >> +                          vcpu_debug_saved_reg(vcpu, mdscr_el1) =
> >> +                                  *vcpu_reg(vcpu, p->Rt);
> >> +                  else
> >> +                          *vcpu_reg(vcpu, p->Rt) =
> >> +                                  vcpu_debug_saved_reg(vcpu, mdscr_el1);
> >
> > With this lines wrapping, {}'s might be nice.
> 
> My natural inclination is to wrap in {}'s but I know the kernel is a fan
> of the single-statement if forms.
> 
It's accepted to use braces for multi-line single statements - and I
prefer it too :)

-Christoffer
_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Reply via email to