On 2015/12/9 0:59, Marc Zyngier wrote:
>> > +  }
>> > +
>> > +  /* If all overflow bits are cleared, kick the vcpu to clear interrupt
>> > +   * pending status.
>> > +   */
>> > +  if (val == 0)
>> > +          kvm_vcpu_kick(vcpu);
> Do we really need to do so? This will be dropped on the next entry
> anyway, so i don't see the need to kick the vcpu again. Or am I missing
> something?
> 
I thought maybe it could not set the interrupt low immediately when all
the overflow bits are cleared for some reason, so add a kick to force it
to sync the interrupt. But as you said, I'll remove this.

Thanks,
-- 
Shannon

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Reply via email to