Hi Shannon,
On 06/12/16 06:41, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.z...@linaro.org>
>
> This is the corresponding part of commit 0d98d00(arm64: KVM:
> vgic-v3: Reset LRs at boot time) which is missed for new-vgic.
>
> Signed-off-by: Shannon Zhao <shannon.z...@linaro.org>
> ---
> virt/kvm/arm/vgic/vgic-v3.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/virt/kvm/arm/vgic/vgic-v3.c b/virt/kvm/arm/vgic/vgic-v3.c
> index 5c9f974..7262f3b 100644
> --- a/virt/kvm/arm/vgic/vgic-v3.c
> +++ b/virt/kvm/arm/vgic/vgic-v3.c
> @@ -307,6 +307,11 @@ int vgic_v3_map_resources(struct kvm *kvm)
> return ret;
> }
>
> +static void vgic_cpu_init_lrs(void *params)
> +{
> + kvm_call_hyp(__vgic_v3_init_lrs);
> +}
> +
> /**
> * vgic_v3_probe - probe for a GICv3 compatible interrupt controller in DT
> * @node: pointer to the DT node
> @@ -361,5 +366,7 @@ int vgic_v3_probe(const struct gic_kvm_info *info)
> kvm_vgic_global_state.type = VGIC_V3;
> kvm_vgic_global_state.max_gic_vcpus = VGIC_V3_MAX_CPUS;
>
> + on_each_cpu(vgic_cpu_init_lrs, NULL, 1);
I don't think that's enough. If you have CPU hotplug, your CPU will come
up with reset values long after boot. I think you need something that is
triggered from cpu_init_hyp_mode/cpu_hyp_reinit.
> +
> return 0;
> }
>
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
