On Mon, Feb 04, 2019 at 09:56:13AM +0000, Alexandru Elisei wrote: > On 2/2/19 3:51 PM, Andrew Jones wrote: > > On Fri, Feb 01, 2019 at 11:16:38AM +0000, Alexandru Elisei wrote: > >> Add configuration option --vmm to specify the virtual machine manager. > >> Valid choices are 'qemu' and 'kvmtool', the default being 'qemu'. This > >> option is only available for the arm and arm64 architectures and does > >> nothing for now. > >> > >> Signed-off-by: Alexandru Elisei <[email protected]> > >> --- > >> configure | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/configure b/configure > >> index 44708b026422..0786e1604dba 100755 > >> --- a/configure > >> +++ b/configure > >> @@ -16,6 +16,7 @@ endian="" > >> pretty_print_stacks=yes > >> environ_default=yes > >> u32_long= > >> +vmm="qemu" > >> > >> usage() { > >> cat <<-EOF > >> @@ -24,6 +25,8 @@ usage() { > >> Options include: > >> --arch=ARCH architecture to compile for ($arch) > >> --processor=PROCESSOR processor to compile for ($arch) > >> + --vmm=VMM virtual machine monitor to compile for (qemu > >> + or kvmtool, default is qemu) (arm/arm64 only) > >> --cross-prefix=PREFIX cross compiler prefix > >> --cc=CC c compiler to use ($cc) > >> --cxx=CXX c++ compiler to use ($cxx) > >> @@ -56,6 +59,9 @@ while [[ "$1" = -* ]]; do > >> --processor) > >> processor="$arg" > >> ;; > >> +--vmm) > >> + vmm="$arg" > >> + ;; > >> --cross-prefix) > >> cross_prefix="$arg" > >> ;; > >> @@ -108,6 +114,10 @@ if [ "$arch" = "i386" ] || [ "$arch" = "x86_64" ]; > >> then > >> testdir=x86 > >> elif [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then > >> testdir=arm > >> + if [ "$vmm" != "qemu" ] && [ "$vmm" != "kvmtool" ]; then > >> + echo '--vmm must be one of "qemu" or "kvmtool"!' > > nit: I'd drop the '!' > There are two error messages following this line, and both have an exclamation > mark. I would like to keep it as it is for consistency, if you're ok with it.
Hmm, yeah, it looks like I added them too. We should drop those. I'll leave it up to you to either add this one or delete the other two. Thanks, drew > > > >> + usage > >> + fi > >> elif [ "$arch" = "ppc64" ]; then > >> testdir=powerpc > >> firmware="$testdir/boot_rom.bin" > >> -- > >> 2.17.0 > >> > > > > Reviewed-by: Andrew Jones <[email protected]> > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
