On 1/13/20 1:48 PM, Alexandru Elisei wrote:
> [..]
>> +    isb();
>> +    report(!gic_timer_pending(info), "not pending before UINT64_MAX (irqs 
>> on)");
> This check can be improved. You want to check the timer CTL.ISTATUS here, not 
> the
> gic. A device (in this case, the timer) can assert the interrupt, but the gic 
> does
> not sample it immediately. Come to think of it, the entire timer test is wrong
> because of this.

I'll write a patch for it in v4 of my fixes series.

Thanks,
Alex


_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Reply via email to