On Sun, Jul 26, 2020 at 12:55:16PM +0100, Marc Zyngier wrote: > On Fri, 24 Jul 2020 15:35:04 +0100, > Will Deacon <[email protected]> wrote: > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index 73e62d360a36..adb933ecd177 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@ -2046,6 +2046,20 @@ static void handle_access_fault(struct kvm_vcpu > > *vcpu, phys_addr_t fault_ipa) > > kvm_set_pfn_accessed(pfn); > > } > > > > +static int handle_error_invalid_dabt(struct kvm_vcpu *vcpu, struct kvm_run > > *run, > > Nit: why the "_error_"? There isn't any error here, only an awkward > part of the architecture. I'd rather see something like > handle_nisv_dabt(), which matches what this function actually does.
I chose "_error_" because this handling the case when kvm_is_error_hva() is true (but I agree that "error" is misleading in both cases). Will _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
