On Mon, Sep 21, 2020 at 02:08:38PM +0100, Alexandru Elisei wrote:
> Update the description of the PMU KVM_{GET, SET}_DEVICE_ATTR error codes
> to be a better match for the code that returns them.
>
> Signed-off-by: Alexandru Elisei <[email protected]>
> ---
> Documentation/virt/kvm/devices/vcpu.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/virt/kvm/devices/vcpu.rst
> b/Documentation/virt/kvm/devices/vcpu.rst
> index 96d6cf77cb1e..5b8db30c61db 100644
> --- a/Documentation/virt/kvm/devices/vcpu.rst
> +++ b/Documentation/virt/kvm/devices/vcpu.rst
> @@ -26,8 +26,8 @@ Returns:
> ======= ========================================================
> -EBUSY The PMU overflow interrupt is already set
> -EFAULT Error reading interrupt number
> - -ENXIO The overflow interrupt not set when attempting to get it
> - -ENODEV PMUv3 not supported
> + -ENXIO PMUv3 not supported
I think -ENXIO matched the code better before the change.
> + -ENODEV KVM_ARM_VCPU_PMU_V3 feature missing from VCPU
> -EINVAL Invalid PMU overflow interrupt number supplied or
> trying to set the IRQ number without using an in-kernel
> irqchip.
> @@ -48,8 +48,8 @@ Returns:
> ======= ======================================================
> -EEXIST Interrupt number already used
> -ENODEV PMUv3 not supported or GIC not initialized
> - -ENXIO PMUv3 not properly configured or in-kernel irqchip not
> - configured as required prior to calling this attribute
> + -ENXIO PMUv3 not supported, missing VCPU feature or interrupt
> + number not set
> -EBUSY PMUv3 already initialized
> ======= ======================================================
>
Thanks,
drew
_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
