On Wed, Jun 09 2021, David Hildenbrand <[email protected]> wrote: > On 09.06.21 16:37, Cornelia Huck wrote: >> Signed-off-by: Cornelia Huck <[email protected]> >> --- >> README.md | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/README.md b/README.md >> index 24d4bdaaee0d..687ff50d0af1 100644 >> --- a/README.md >> +++ b/README.md >> @@ -156,6 +156,15 @@ Exceptions: >> >> - While the kernel standard requires 80 columns, we allow up to 120. >> >> +Header guards: >> + >> +Please try to adhere to adhere to the following patterns when adding >> +"#ifndef <...> #define <...>" header guards: >> + ./lib: _HEADER_H_ >> + ./lib/<ARCH>: _ARCH_HEADER_H_ >> + ./lib/<ARCH>/asm: _ASMARCH_HEADER_H_ > > I'd have used _ARCH_ASM_HEADER_H_
I had that first, but the pattern I ended up using caused way less churn (this is basically what arm[64] uses.) > > Reviewed-by: David Hildenbrand <[email protected]> Thanks! _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
