On Tue, Sep 21, 2021 at 01:01:19AM +0000, Oliver Upton wrote: > Building demand_paging_test.c with clang throws the following warning: > > >> demand_paging_test.c:182:7: error: logical not is only applied to the left > >> hand side of this bitwise operator [-Werror,-Wlogical-not-parentheses] > if (!pollfd[0].revents & POLLIN) > > Silence the warning by placing the bitwise operation within parentheses. > > Signed-off-by: Oliver Upton <[email protected]> > --- > tools/testing/selftests/kvm/demand_paging_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/demand_paging_test.c > b/tools/testing/selftests/kvm/demand_paging_test.c > index e79c1b64977f..10edae425ab3 100644 > --- a/tools/testing/selftests/kvm/demand_paging_test.c > +++ b/tools/testing/selftests/kvm/demand_paging_test.c > @@ -179,7 +179,7 @@ static void *uffd_handler_thread_fn(void *arg) > return NULL; > } > > - if (!pollfd[0].revents & POLLIN) > + if (!(pollfd[0].revents & POLLIN))
That's a bug fix. If revents was e.g. POLLPRI then this logic wouldn't have done what it's supposed to do. Maybe we should better call out that this is a fix in the summary and add a fixes tag? Anyway, Reviewed-by: Andrew Jones <[email protected]> Thanks, drew > continue; > > r = read(uffd, &msg, sizeof(msg)); > -- > 2.33.0.464.g1972c5931b-goog > _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
