Hi Gavin On 8/15/21 2:13 AM, Gavin Shan wrote: > This supports SDEI_VERSION hypercall by returning v1.0.0 simply s/This supports/Add Support. I think this is the prefered way to start the commit msg. Here and elsewhere. > when the functionality is supported on the VM and vCPU. Can you explain when the functionality isn't supported on either. From the infra patch I have the impression that an allocation failure is the sole cause of lack of support? > > Signed-off-by: Gavin Shan <[email protected]> > --- > arch/arm64/kvm/sdei.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/kvm/sdei.c b/arch/arm64/kvm/sdei.c > index ab330b74a965..aa9485f076a9 100644 > --- a/arch/arm64/kvm/sdei.c > +++ b/arch/arm64/kvm/sdei.c > @@ -70,6 +70,22 @@ static void kvm_sdei_remove_vcpu_events(struct kvm_vcpu > *vcpu) > } > } > > +static unsigned long kvm_sdei_hypercall_version(struct kvm_vcpu *vcpu) > +{ > + struct kvm *kvm = vcpu->kvm; > + struct kvm_sdei_kvm *ksdei = kvm->arch.sdei; > + struct kvm_sdei_vcpu *vsdei = vcpu->arch.sdei; > + unsigned long ret = SDEI_NOT_SUPPORTED; nit: I would remove ret local variable > + > + if (!(ksdei && vsdei)) > + return ret; > + > + /* v1.0.0 */ > + ret = (1UL << SDEI_VERSION_MAJOR_SHIFT); > + > + return ret; > +} > + > int kvm_sdei_hypercall(struct kvm_vcpu *vcpu) > { > u32 func = smccc_get_function(vcpu); > @@ -78,6 +94,8 @@ int kvm_sdei_hypercall(struct kvm_vcpu *vcpu) > > switch (func) { > case SDEI_1_0_FN_SDEI_VERSION: > + ret = kvm_sdei_hypercall_version(vcpu); > + break; > case SDEI_1_0_FN_SDEI_EVENT_REGISTER: > case SDEI_1_0_FN_SDEI_EVENT_ENABLE: > case SDEI_1_0_FN_SDEI_EVENT_DISABLE: >
Eric _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
