On Thu, Jan 20, 2022 at 09:39:04AM -0800, Ricardo Koller wrote: > The val argument in gicv3_access_reg can have any value when used for a > read, not necessarily 0. Fix the assert by checking val only for > writes. > > Signed-off-by: Ricardo Koller <ricar...@google.com> > Reported-by: Reiji Watanabe <rei...@google.com> > Cc: Andrew Jones <drjo...@redhat.com> > --- > tools/testing/selftests/kvm/lib/aarch64/gic_v3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/lib/aarch64/gic_v3.c > b/tools/testing/selftests/kvm/lib/aarch64/gic_v3.c > index 00f613c0583c..e4945fe66620 100644 > --- a/tools/testing/selftests/kvm/lib/aarch64/gic_v3.c > +++ b/tools/testing/selftests/kvm/lib/aarch64/gic_v3.c > @@ -159,7 +159,7 @@ static void gicv3_access_reg(uint32_t intid, uint64_t > offset, > uint32_t cpu_or_dist; > > GUEST_ASSERT(bits_per_field <= reg_bits); > - GUEST_ASSERT(*val < (1U << bits_per_field)); > + GUEST_ASSERT(!write || *val < (1U << bits_per_field)); > /* Some registers like IROUTER are 64 bit long. Those are currently not > * supported by readl nor writel, so just asserting here until then. > */ > -- > 2.35.0.rc0.227.g00780c9af4-goog >
Reviewed-by: Andrew Jones <drjo...@redhat.com> _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
