Hi :) I'm really sorry i dropped the ball on this!! Has it been solved? I'm not sure what positive suggestions i could have made to be honest. :( It's good to hear that 1-based would make sense to someone experienced with Base. The first place where i think i understand enough is the
" // NumberFormat generates it's value from Value and Language and that completes it's task. " but i think i was helped there because it's exactly what you said. Many apols and regards from Tom :) >________________________________ > From: klaus-jürgen weghorn ol <[email protected]> >To: Libreoffice Translation List <[email protected]> >Sent: Monday, 18 March 2013, 15:28 >Subject: Re: [libreoffice-l10n] Help reviewing comment translation (German -> >English) > > >Am 18.03.2013 15:46, schrieb Tom Davies: >> Hi :) >> It does kinda make grammatical sense but it's not clear what is really >> meant. For example >> >> "Number in the standard format, the other on the cursor position" begs the >> question "the other what?". The 1st thing talks about format and the 2nd >> talks about position. Normally one would distinguish both things by >> position or both by formats. Does it make sense in German? Hopefully it >> becomes clear when you see context. Perhaps coding provides the context. >> >> "alles erlaubt" = all ?? > >"all allowed" or "all permitted" or better "Anything goes" > >> >> "Table for Basic is 1-based" probably makes sense to devs but perhaps meant >> to say that the table is to base 1, but that doesn't sound plausible. >> Binary is base-2. Decimal is base-10. There is probably some special >> notation but i've just written it as it would be spoken. Hopefully i'm off >> track anyway and devs would understand. > >I think "1-based" is a technical term in Base. > >> " // disable if already set default" perhaps should be " // disable if >> already set to default" or " // disable if already set as default". For >> the 1st suggestion it doesn't actually tell you anything about what the >> default value is so it's a more generic answer. The 2nd case is a statement >> that the attempt to change whatever is disabled because the new value is >> already the same as the current default. >> >> " // NumberFormat generate value from Value and Language and bagging" >> probably needs to be "generates". Not sure what "bagging" means. Perhaps >> "packaging" or "containing"? > >"eintüten" is here some kind of colloquial and means "to box" or "to >finish" or "to put". > >For me as a non developer it is a different grammatical sense by >"NumberFormat generate value" to the German explanation. The English >sentence means: "The NumberFormat generates the Value from Value and >Language" but it means in German: You (or sb. else) generate the >NumberFormat Value from Value and Language". > >So it would be "Generate NumberFormat Value from Value and Language and >box it." > >> Does "nur" really mean "only" rather than "not" or something else negative? > >It means "only" > >> >> >>> ________________________________ >>> From: Lior Kaplan <[email protected]> >>> To: klaus-jürgen weghorn ol <[email protected]> >>> Cc: Libreoffice Translation List <[email protected]> >>> Sent: Monday, 18 March 2013, 12:58 >>> Subject: Re: [libreoffice-l10n] Help reviewing comment translation (German >>> -> English) >>> >>> diff --git a/sc/source/ui/view/tabvwsha.cxx b/sc/source/ui/view/tabvwsha.cxx >>> index 979591a..a33a5a2 100644 >>> --- a/sc/source/ui/view/tabvwsha.cxx >>> +++ b/sc/source/ui/view/tabvwsha.cxx >>> @@ -102,7 +102,7 @@ sal_Bool ScTabViewShell::GetFunction( String& rFuncStr, >>> sal_uInt16 nErrCode ) >>> aStr += '0'; >>> else >>> { >>> - // Anzahl im Standardformat, die anderen nach >>> Cursorposition >>> + // Number in the standard format, the other on the cursor >>> position >>> SvNumberFormatter* pFormatter = pDoc->GetFormatTable(); >>> sal_uInt32 nNumFmt = 0; >>> if ( eFunc != SUBTOTAL_FUNC_CNT && eFunc != >>> SUBTOTAL_FUNC_CNT2 ) >>> @@ -137,7 +137,7 @@ sal_Bool ScTabViewShell::GetFunction( String& rFuncStr, >>> sal_uInt16 nErrCode ) >>> >>> >>> >>> -// Funktionen, die je nach Selektion disabled sind >>> +// Functions that are disabled, depending on the selection >>> // Default: >>> // SID_DELETE, >>> // SID_DELETE_CONTENTS, >>> @@ -223,8 +223,10 @@ void ScTabViewShell::GetState( SfxItemSet& rSet ) >>> >>> case SID_SEARCH_OPTIONS: >>> { >>> - sal_uInt16 nOptions = 0xffff; // alles erlaubt >>> - // wenn ReadOnly, kein >>> Ersetzen: >>> + // alles erlaubt >>> + sal_uInt16 nOptions = 0xffff; >>> + >>> + // No replacement if ReadOnly >>> if (GetViewData()->GetDocShell()->IsReadOnly()) >>> nOptions &= ~( SEARCH_OPTIONS_REPLACE | >>> SEARCH_OPTIONS_REPLACE_ALL ); >>> rSet.Put( SfxUInt16Item( nWhich, nOptions ) ); >>> @@ -243,7 +245,7 @@ void ScTabViewShell::GetState( SfxItemSet& rSet ) >>> break; >>> >>> case SID_CURRENTTAB: >>> - // Tabelle fuer Basic ist 1-basiert >>> + // Table for Basic is 1-based >>> rSet.Put( SfxUInt16Item( nWhich, >>> static_cast<sal_uInt16>(GetViewData()->GetTabNo()) + 1 ) ); >>> break; >>> >>> @@ -272,7 +274,7 @@ void ScTabViewShell::GetState( SfxItemSet& rSet ) >>> >>> case FID_RESET_PRINTZOOM: >>> { >>> - // disablen, wenn schon Default eingestellt >>> + // disable if already set default >>> >>> String aStyleName = pDoc->GetPageStyle( nTab ); >>> ScStyleSheetPool* pStylePool = >>> pDoc->GetStyleSheetPool(); >>> @@ -441,13 +443,13 @@ void ScTabViewShell::GetState( SfxItemSet& rSet ) >>> break; >>> >>> case SID_FORMATPAGE: >>> - //! bei geschuetzten Tabellen ??? >>> + // in protected tables >>> if ( pDocShell && ( pDocShell->IsReadOnly() || >>> pDocShell->IsDocShared() ) ) >>> rSet.DisableItem( nWhich ); >>> break; >>> >>> case SID_PRINTPREVIEW: >>> - // Toggle-Slot braucht einen State >>> + // Toggle slot needs a State >>> rSet.Put( SfxBoolItem( nWhich, false ) ); >>> break; >>> >>> @@ -480,7 +482,7 @@ void ScTabViewShell::ExecuteCellFormatDlg( SfxRequest& >>> rReq, sal_uInt16 nTabPage >>> >>> pOldAttrs->GetItemSet() ); >>> >>> >>> - // Umrandungs-Items holen und in den Set packen: >>> + // Get border items and put them in the set: >>> GetSelectionFrame( aLineOuter, aLineInner ); >>> //Fix border incorrect for RTL fdo#62399 >>> if( pDoc->IsLayoutRTL( GetViewData()->GetTabNo() ) ) >>> @@ -502,7 +504,7 @@ void ScTabViewShell::ExecuteCellFormatDlg( SfxRequest& >>> rReq, sal_uInt16 nTabPage >>> >>> pOldSet->Put( aLineInner ); >>> >>> - // NumberFormat Value aus Value und Language erzeugen und eintueten >>> + // NumberFormat generate value from Value and Language and bagging >>> pOldSet->Put( SfxUInt32Item( ATTR_VALUE_FORMAT, >>> pOldAttrs->GetNumberFormat( pDoc->GetFormatTable() ) ) ); >>> >>> @@ -708,9 +710,9 @@ void ScTabViewShell::UpdateInputHandlerCellAdjust( >>> SvxCellHorJustify eJust ) >>> >>> void ScTabViewShell::ExecuteSave( SfxRequest& rReq ) >>> { >>> - // nur SID_SAVEDOC / SID_SAVEASDOC >>> + // only SID_SAVEDOC / SID_SAVEASDOC >>> >>> - // Eingabe auf jeden Fall abschliessen, auch wenn eine Formel >>> bearbeitet wird >>> + // Finish entering in any case, even if a formula is being processed >>> SC_MOD()->InputEnterHandler(); >>> >>> if ( GetViewData()->GetDocShell()->IsDocShared() ) >>> @@ -718,7 +720,7 @@ void ScTabViewShell::ExecuteSave( SfxRequest& rReq ) >>> GetViewData()->GetDocShell()->SetDocumentModified(); >>> } >>> >>> - // ansonsten normal weiter >>> + // otherwise as normal >>> GetViewData()->GetDocShell()->ExecuteSlot( rReq ); >>> } >>> >>> >>> On Mon, Mar 18, 2013 at 2:29 PM, klaus-jürgen weghorn ol < >>> [email protected]> wrote: >>> >>>> Hi, >>>> Am 18.03.2013 13:06, schrieb Lior Kaplan: >>>>> Hi, >>>>> >>>>> Could someone review this Google translation of comment from German to >>>>> English ? (see the attached file) >>>> >>>> No attached file because of ml. >>>> >>>> >>>> -- >>>> Grüße >>>> k-j >>>> >>>> -- >>>> Unsubscribe instructions: E-mail to [email protected] >>>> Problems? >>>> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ >>>> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette >>>> List archive: http://listarchives.libreoffice.org/global/l10n/ >>>> All messages sent to this list will be publicly archived and cannot be >>>> deleted >>>> >>> >>> -- >>> Unsubscribe instructions: E-mail to [email protected] >>> Problems? >>> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ >>> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette >>> List archive: http://listarchives.libreoffice.org/global/l10n/ >>> All messages sent to this list will be publicly archived and cannot be >>> deleted >>> >>> >>> > > >-- >Grüße >k-j > >-- >Unsubscribe instructions: E-mail to [email protected] >Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ >Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette >List archive: http://listarchives.libreoffice.org/global/l10n/ >All messages sent to this list will be publicly archived and cannot be deleted > > > -- Unsubscribe instructions: E-mail to [email protected] Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/l10n/ All messages sent to this list will be publicly archived and cannot be deleted
