Hi,
Sorry, another comment resulting from the review of
draft-ietf-l1vpn-ospf-auto-discovery and draft-ietf-l1vpn-basic-mode
Figure 2 shows the format of the auto-discovery information. But
draft-ietf-l1vpn-basic-mode already defines this format and requires that it
is common to all auto-discovery mechanisms.
You should avoid this redefinition since it opens up scope for
incompatibilities. Instead you should simple reference
draft-ietf-l1vpn-basic-mode.
But note that in my review of draft-ietf-l1vpn-basic-mode I will suggest
that that draft should not include the one octet length field as a part of
the required encoding. Thus, I suggest:
draft-ietf-l1vpn-basic-mode should show
+---------------------------------------+
| PPI Length (1 octet) |
+---------------------------------------+
| PPI (variable) |
+---------------------------------------+
| CPI AFI (2 octets) |
+---------------------------------------+
| CPI (length) |
+---------------------------------------+
| CPI (variable) |
+---------------------------------------+
draft-ietf-l1vpn-ospf-auto-discovery should be unchanged with its reference
to draft-ietf-l1vpn-basic-mode
draft-ietf-l1vpn-bgp-auto-discovery should show
+---------------------------------------+
| Length (1 octet) |
+---------------------------------------+
| Auto-discovery info (variable) |
+---------------------------------------+
and the descriptive text should simple reference
draft-ietf-l1vpn-basic-mode
Cheers,
Adrian
_______________________________________________
L1vpn mailing list
L1vpn@lists.ietf.org
https://www1.ietf.org/mailman/listinfo/l1vpn
