On Tue, 2008-09-16 at 01:24 -0400, Ryan McKinley wrote:
> I'm looking over AbstractDroid and can't figure out what a lot of it  
> does (if anything)
> 
> There seem to be a lot of public setters on functions that would surly  
> wreck havoc if they were ever set externally.
> 
> Consider:
>    setPool()
>   setRunningWorker()

+1

> 
> Also, a few variables don't appear to have any real use:
>   freeSlots
>   runningThreads
>   taskDate  -- set once when the droid starts?!  it should be  
> initialized when the task starts

AFAIR that is to identify one common start stamp, it is thought for
incremental crawls but since that is not implemented yet. 

I need to look into them but: We are using the commit-then-review
approach. I will review the commit. :)

> The accurate value would be calculated from the ThreadPoolExecutor

+1

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to