On 17/09/2008, Thorsten Scherler <[EMAIL PROTECTED]> wrote: > On Tue, 2008-09-16 at 14:57 -0400, Ryan McKinley wrote: > > Looking over the API some more... > > > > Is the (can the) Queue be Task agnostic? That is, can the Queue > > accept any task even if invalid? > > > We do not have any criteria till now to decide whether a task is valid > or not. > > > > Can we move all acceptX() methods? > > > Not sure what you mean, which acceptX method? > > > > > > I like this because it pushes validation logic elsewhere and makes the > > Queue very general. The only bit that does not work well is a maxSize > > concept on Queue. What is the expected behavior when you hit the > > maxSize? > > > The default behavior ATM that we stop processing. We should at least add > a note in the log to explain that we reached the defined max size and > will abort. > > > > perhaps we can add an isFull() method to Queue > > > This will return if the queue size = maxSize?
Minor nit: It's safer to use queue size >= maxSize > > Yeah, why not. > > salu2 > > > > > > ryan > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > -- > Thorsten Scherler thorsten.at.apache.org > Open Source Java consulting, training and solutions > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
