It fixed the problems I had. Thanks the rewrite! Jaakko
On Mon, Jul 20, 2009 at 9:05 PM, Craig Andrews <[email protected]>wrote: > I rewrote how multipart messages are handled. > > Here's the commit in my branch: > > http://gitorious.org/~candrews/laconica/candrews-clone/commit/6313cf5bfe00c2810f1cdc0ac558643543e5f02f<http://gitorious.org/%7Ecandrews/laconica/candrews-clone/commit/6313cf5bfe00c2810f1cdc0ac558643543e5f02f> > > Can you test out the branch > > http://gitorious.org/~candrews/laconica/candrews-clone/commits/change-mail-handling<http://gitorious.org/%7Ecandrews/laconica/candrews-clone/commits/change-mail-handling> > with the mail systems that were seeing problems, and tell me if these > changes fix them? > > > I would opt for taking always text/plain as the notice text until someone > > gives a very good reason to take html part. Ignore the text/html (looks > > like > > this is how identi.ca operates) and other bodies which are not supported > > by > > your laconi.ca instance. > > > > However, there can be some email services (I know at least one) which > will > > only send text/html, I guess. Taking the notice text out of the html can > > be > > a really cumbersome thing. > > > > Jaakko > > > > On Mon, Jul 20, 2009 at 7:55 PM, Craig Andrews > > <[email protected]>wrote: > > > >> > It looks like that maildaemon.php doesn't handle some multipart bodies > >> > correctly. Especially when the mail body is like this: > >> > > >> > multipart/mixed > >> > multipart/alternative > >> > text/plain > >> > text/html > >> > image/jpeg > >> > >> In this case, how does one tell which part of the email is the body > >> (which > >> should become the notice text) and which part(s) are the attachments? > >> > >> > I made a correction which fixes the problem into my laconi.ca clone. > >> If > >> > you > >> > want to check it, it is here > >> > > >> > http://gitorious.org/~jaakko/laconica/jaakkos-clone/commit/1f1dbfec3a0eff0bbc79bb9db1b488d57a63ce28<http://gitorious.org/%7Ejaakko/laconica/jaakkos-clone/commit/1f1dbfec3a0eff0bbc79bb9db1b488d57a63ce28> > < > http://gitorious.org/%7Ejaakko/laconica/jaakkos-clone/commit/1f1dbfec3a0eff0bbc79bb9db1b488d57a63ce28 > > > >> > I could do a merge request if there is a need and will. > >> > >> I just looked over the patch, and imported it into my local copy, and am > >> trying it now. I agree with the comment "This will also store the > >> text/html body. Should be fixed." but I don't know how to tell if the > >> sender meant for that "text/html" part to be an attachment, or an > >> alternative. How does one know? > >> > > >> > Jaakko > >> > >> Thanks, > >> ~Craig > >> > >> > > > > > > -- > > Jaakko > > > > > -- Jaakko Sent from Helsinki, ES, Finland
_______________________________________________ Laconica-dev mailing list [email protected] http://mail.laconi.ca/mailman/listinfo/laconica-dev
