Brenda Wallace wrote:
After being invaded by spammers yesteday, I made my first laconica plugin.
It's spam filter using Mollom - the bayesian filter webservice from
the Drupal project leader Dries.
http://coffee.geek.nz/mollom-plugin-laconica.html
Feedback welcome.
A couple of things:
* Good idea! We probably need to add this and an Akismet plugin to
the core.
* You're doing wayyy too much XML-RPC stuff yourself. Check out the
LinkBack plugin; way easier.
* Is this in git somewhere?
* Please don't recommend that people put /anything/ in default
folders like 'plugins'. Local content and code should go in the
'local' subdirectory, so it doesn't get stomped on at upgrade
time. That's what 'local' is there for!
* You've got a lot of dead code in there (commented out) that makes
it practically impossible to read.
* You didn't change the class comment when you copied it from the
Blogspam server.
* I get a lot of false positives from the Bayesian analysis on
Blogspam (which is why we don't use it on identi.ca). Stuff that's
inappropriate for blog comments ("Hello") is fine for
microblogging. How's Mollom working out?
-Evan
--
Evan Prodromou
CEO, Control Yourself, Inc.
[email protected] - http://identi.ca/evan - +1-514-554-3826
_______________________________________________
Laconica-dev mailing list
[email protected]
http://mail.laconi.ca/mailman/listinfo/laconica-dev
