Revision: 6525
http://languagetool.svn.sourceforge.net/languagetool/?rev=6525&view=rev
Author: dnaber
Date: 2012-02-13 17:32:17 +0000 (Mon, 13 Feb 2012)
Log Message:
-----------
fixed a bug in the POS tagger incorrectly returning lowercase word (patch by
Maksym Davydov)
Modified Paths:
--------------
trunk/JLanguageTool/CHANGES.txt
trunk/JLanguageTool/src/java/org/languagetool/tagging/uk/UkrainianMyspellTagger.java
trunk/JLanguageTool/src/test/org/languagetool/rules/UppercaseSentenceStartRuleTest.java
Modified: trunk/JLanguageTool/CHANGES.txt
===================================================================
--- trunk/JLanguageTool/CHANGES.txt 2012-02-13 00:15:25 UTC (rev 6524)
+++ trunk/JLanguageTool/CHANGES.txt 2012-02-13 17:32:17 UTC (rev 6525)
@@ -18,6 +18,9 @@
-Russian:
-fixed some false alarms
-added a few new rules
+ -Ukrainian:
+ -fixed a bug in the POS tagger incorrectly returning lowercase word,
breaking
+ the rule that checks for uppercase sentence starts (Maksym Davydov)
-bugfix: the "fromx" position in the XML output was wrong sometimes
-bugfix: the "contextoffset" position in the XML output was wrong
Modified:
trunk/JLanguageTool/src/java/org/languagetool/tagging/uk/UkrainianMyspellTagger.java
===================================================================
---
trunk/JLanguageTool/src/java/org/languagetool/tagging/uk/UkrainianMyspellTagger.java
2012-02-13 00:15:25 UTC (rev 6524)
+++
trunk/JLanguageTool/src/java/org/languagetool/tagging/uk/UkrainianMyspellTagger.java
2012-02-13 17:32:17 UTC (rev 6525)
@@ -124,9 +124,9 @@
if (!word.equals(lowerWord)) {
lowerPosTags = wordsToPos.get(lowerWord);
if (lowerPosTags != null) {
- for (String lowerPosTag : lowerPosTags)
- analyzedTokens.add(new AnalyzedToken(lowerWord, lowerPosTag,
- lowerWord));
+ for (String lowerPosTag : lowerPosTags) {
+ analyzedTokens.add(new AnalyzedToken(word, lowerPosTag,
lowerWord));
+ }
}
}
// else {
Modified:
trunk/JLanguageTool/src/test/org/languagetool/rules/UppercaseSentenceStartRuleTest.java
===================================================================
---
trunk/JLanguageTool/src/test/org/languagetool/rules/UppercaseSentenceStartRuleTest.java
2012-02-13 00:15:25 UTC (rev 6524)
+++
trunk/JLanguageTool/src/test/org/languagetool/rules/UppercaseSentenceStartRuleTest.java
2012-02-13 17:32:17 UTC (rev 6525)
@@ -24,6 +24,7 @@
import junit.framework.TestCase;
import org.languagetool.JLanguageTool;
import org.languagetool.Language;
+import org.languagetool.TestTools;
/**
* @author Daniel Naber
@@ -94,5 +95,21 @@
matches = langTool.check("To jest lista punktowana:\n\npunkt
pierwszy,\n\npunkt drugi,\n\npunkt trzeci.");
assertEquals(0, matches.size());
}
-
+
+ public void testUkrainian() throws IOException {
+ final UppercaseSentenceStartRule rule = new
UppercaseSentenceStartRule(TestTools.getEnglishMessages(), Language.UKRAINIAN);
+
+ final JLanguageTool langTool = new JLanguageTool(Language.UKRAINIAN);
+
+ // correct sentences:
+ RuleMatch[] matches = rule.match(langTool.getAnalyzedSentence("Автор
написав це речення з великої літери."));
+ assertEquals(0, matches.length);
+
+ // incorrect sentences:
+ matches = rule.match(langTool.getAnalyzedSentence("автор написав це
речення з маленької літери."));
+ assertEquals(1, matches.length);
+ assertEquals(1, matches[0].getSuggestedReplacements().size());
+ assertEquals("Автор", matches[0].getSuggestedReplacements().get(0));
+ }
+
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Languagetool-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/languagetool-cvs
